[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH] window: move window again after fullscreen



----- Original Message -----
> From: "Marc-André Lureau" <marcandre lureau gmail com>
> To: virt-tools-list redhat com
> Sent: Friday, October 4, 2013 8:13:08 AM
> Subject: [virt-tools-list] [PATCH] window: move window again after fullscreen
> 
> Some WM get fullscreen position wrong, in some racy ways (metacity on
> rhel6 for instance).  Setting window position after entering fullscreen
> seems to solve the problem. Though it's better to move before entering
> fullscreen, to avoid extra resizes.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=809546
> ---
>  src/virt-viewer-window.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index 0f62feb..d6b1c54 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -552,6 +552,9 @@ virt_viewer_window_enter_fullscreen(VirtViewerWindow
> *self, gint monitor)
>      virt_viewer_window_move_to_monitor(self);
>  
>      gtk_window_fullscreen(GTK_WINDOW(priv->window));
> +
> +    /* move again, some WM get fullscreen position wrong, in some racy
> ways.. */
> +    virt_viewer_window_move_to_monitor(self);
>  }
>  
>  #define MAX_KEY_COMBO 4
> --
> 1.8.3.1
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list redhat com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
> 


I mentioned this via IRC already, but I suspect that this workaround may not work properly when client monitors are different resolutions due to the fact that we ignore further allocations after the first one when we go into fullscreen mode. Can you get somebody to test this?


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]