[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [PATCH 0/4] fix RNG devices support



On 10/25/2013 11:13 AM, Giuseppe Scrivano wrote:
> The current implementation of RNG devices doesn't support correctly
> the case where the UDP protocol is used to communicate with the server
> and the bind/connect mode paradigm doesn't make sense.
> 
> This series change the implementation to be closer to virtual char
> devices.
> 
> Giuseppe Scrivano (4):
>   virtinst: allow EGD RNG devices to have both bind and connect sources
>   virt-install: EGD RNG devs need a host to connect to if
>     backend_mode=bind
>   virt-manager: fix adding EGD RNG devices in UDP mode
>   virt-manager: show correctly EGD RNG devices information
> 
>  man/virt-install.pod                      |  15 +++
>  tests/clitest.py                          |   7 +-
>  tests/xmlparse-xml/change-rng-egd-in.xml  |   1 +
>  tests/xmlparse-xml/change-rng-egd-out.xml |   5 +-
>  tests/xmlparse.py                         |   9 +-
>  ui/addhardware.ui                         | 177 ++++++++++++++++++++++--------
>  ui/details.ui                             | 144 ++++++++++++++----------
>  virtManager/addhardware.py                |  99 +++++++++++++----
>  virtManager/details.py                    |  38 ++++---
>  virtinst/cli.py                           |  19 +++-
>  virtinst/devicerng.py                     |  43 ++++++--
>  11 files changed, 400 insertions(+), 157 deletions(-)
> 

ACK series, though I'll probably try and rework the char <source> handling to
be closer to what libvirt models internally (when I get some time that is).

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]