[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-viewer v2 4/4] Hide all windows on disconnection



On Wed, Oct 30, 2013 at 07:53:13AM -0400, Marc-André Lureau wrote:
> Why is app->priv->main_window special cased? It should be already window 0.

Ah ok, I'll change it then, I didn't really look a lot at main_window vs
windows so didn't notice.

> 
> tbh, I think g_hash_table_foreach() would be simpler (like done with the rest of the code).

I'll change it for consistency reasons, but imo it makes things less
readable.

Christophe

Attachment: pgpm9V53jGHXw.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]