[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager PATCH 0/3] Polish the usage of addresses, controllers etc.



On 09/03/2013 12:06 AM, Cole Robinson wrote:
> On 09/02/2013 11:21 AM, Martin Kletzander wrote:
>> *BLURB*
>>
>> Martin Kletzander (3):
>>   Add support for multifunction address parameter
>>   Automatically add multifunction address parameter when needed
>>   Fix addresses in manual
>>
>>  man/virt-install.pod                        |  9 ++++++---
>>  tests/cli-test-xml/compare/many-devices.xml |  4 ++--
>>  virtinst/device.py                          |  3 ++-
>>  virtinst/guest.py                           | 23 +++++++++++++++++++++++
>>  virtinst/xmlbuilder.py                      | 14 +++++++++++---
>>  5 files changed, 44 insertions(+), 9 deletions(-)
>>
> 
> ACK series, but does the first patch not cause test failures? I added a bit to
> test which should fail if an XMLProperty is added and it isn't explicitly
> checked in tests/xmlparse.py. If it is broken, don't bother reposting, just
> fix and push.
> 

The test was OK (with 2 tests skipped) after every single commit and it
is the same after I rebased on current HEAD.

So it is pushed now, thanks for the review,
Martin


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]