[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [RFC PATCH 2/3] virt-install: add support for virtio-rng devices



On 09/18/2013 09:29 AM, Giuseppe Scrivano wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan redhat com>
> ---
>  man/virt-install.pod | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
>  tests/clitest.py     |  6 ++++++
>  virt-install         |  1 +
>  virtinst/cli.py      | 40 ++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 96 insertions(+)
> 

Looks good, I've pushed patches 1 and 2, thanks!

Can you add a follow on patch here? I'd like a simple mode like

--rng /dev/random

which just does the right thing. You can probably just check for the presence
of a leading slash in the implied 'type' pulled from the opstring to mean
type=random device=%(type)s . Then please include that example in the --help
output, man page, etc, since that's likely the most common usecase.

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]