[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [RFC PATCH] set the full screen toolbar to 3px



On 09/24/2013 07:59 PM, Giuseppe Scrivano wrote:
> Signed-off-by: Giuseppe Scrivano <gscrivan redhat com>
> ---
> 
> looking at bz 1008770 reminded me of the first time I've used
> virt-manager: it was quite difficult to understand how to exit
> full-screen mode once you are trapped there.  The attached patch is
> not enough but could be a first step (As a side effect, it will also
> workaround the problem in 1008770).
> 
> What do you think about making the tool-bar more thick?  Do you have
> any other idea?  The first time full-screen mode is used we can
> display a tool-tip?
> 

When we switch to full screen, the toolbar should be displayed for a moment
before retracting to give a visual hint of where it went. It seems to only do
that on the first fullscreening though, but I fixed it upstream now. I also
made the toolbar retract a bit slower to be more deliberate.

As for the patch, the result doesn't look to intrusive to me, but we'd be
deviating from what virt-viewer, vinagre, and other users of this widget do.
My understanding is that this originally came from vmware workstation or
player or similar, might be worth seeing how they work with compiz WRT the
referenced bug. If even they have problems then I don't really feel like
changing anything from virt-manager's side since compiz obviously has bigger
problems.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]