[virt-tools-list] [virt-manager 1/3] virtinst: add support for panic device

Cole Robinson crobinso at redhat.com
Mon Jan 6 20:26:32 UTC 2014


On 01/06/2014 03:04 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  virtinst/__init__.py    |  1 +
>  virtinst/device.py      |  4 +++-
>  virtinst/devicepanic.py | 44 ++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 48 insertions(+), 1 deletion(-)
>  create mode 100644 virtinst/devicepanic.py
> 

Thanks for the patches. Code looks fine here, but please also add a test case
with this commit: at least some test cases in tests/xmlparse.py and a device
add case in tests/xmlconfig.py:testManyDevices.

commit 8abcae50733c10a06de394248612aef0e8405c90 has some examples here.

- Cole




More information about the virt-tools-list mailing list