[virt-tools-list] [virt-manager PATCH] pylint: Skip hashlib import hackery and remove unused variable

Martin Kletzander mkletzan at redhat.com
Mon Jan 20 16:17:20 UTC 2014


On Mon, Jan 20, 2014 at 10:30:25AM -0500, Cole Robinson wrote:
> On 01/20/2014 09:19 AM, Giuseppe Scrivano wrote:
> > Martin Kletzander <mkletzan at redhat.com> writes:
> >
> >> hashlib's dynamic import hackery makes pylint very sad since it cannot
> >> realize that the module has sha256 member (just created dynamically),
> >> so let's just make it skip this error.
> >>
> >> Also remove unused variable in virtinst.cli
> >>
> >> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> >> ---
> >>  virtinst/cli.py       | 3 +--
> >>  virtinst/virtimage.py | 4 ++--
> >>  2 files changed, 3 insertions(+), 4 deletions(-)
> >
>
> Newer pylint should be smart enough to avoid that error, but disabling it is
> fine too.
>
> ACK
>

Yep, looks like it, but I was still stuck with 0.28 :( Updated to
1.1.0 (even though it's not in my distro repository anywhere) and this
particular error is OK.  However there are maybe hundreds of different
errors (maybe configuration problem).  However, thanks for having a
look at this, hopefully this will clear up the results after testing
my next patch.

Pushed now,

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140120/a915a5dc/attachment.sig>


More information about the virt-tools-list mailing list