[virt-tools-list] [PATCH virt-viewer 0/2] Initial support for building with meson/ninja

[Eduardo Lima (Etrunko)]

On 10/4/18 9:41 AM, Eduardo Lima (Etrunko) wrote:
> On 10/4/18 7:48 AM, Daniel P. Berrangé wrote:
>> On Wed, Sep 12, 2018 at 11:07:57AM +0200, Eduardo Lima (Etrunko) wrote:
>>> The first patch is a preparation for the new build system. As it uses
>>> a built in function provided by meson for generating the enum files, it
>>> is not possible to run sed on the resulting file, so we need to keep it
>>> as is.
>>>
>>> As for the build itself, the only missing features are windows related,
>>> which I don't really know how to implement, but should not be difficult.
>>
>> IIUC, this series adds meson support, but leaves the autotools
>> support unchanged.
>>
> 
> Correct.
> 
>> I really don't like the idea of maintaining 2 build systems at
>> the same time. It will inevitably lead to obscure bugs that depend
>> on which build system is used. We've already suffered from this with
>> GTK itself supporting both and their developers & CI only ever testing
>> meson leading autotools to break.
>>
> 
> In SPICE we added meson support as a "unofficial", because there are
> still some unresolved issues in meson when it comes to distribution of
> source tarballs with generated files. The plan is to switch by the
> moment those are fixed.
> 
>> I'm a big fan of meson so I think we should simply do a straight
>> switch. The main question is when, and that's largely determined
>> by what platforms we care about.
>>
>>
> 
> It is easy enough to remove the autotools support, but I would first
> make sure meson will cover all the use cases, especially things that are
> done when autobuild.sh is run, and windows build, which this series
> don't cover.
> 

And btw, my github repository has the patches if someone may find it
easier to add the remote (branch is meson).

https://github.com/etrunko/virt-viewer.git

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com