[virt-tools-list] [PATCH vhostmd 2/2] vm-dump-metrics: Fix WITH_XENSTORE logic

Jim Fehlig jfehlig at suse.com
Tue Oct 30 16:08:02 UTC 2018


On 10/30/18 3:41 AM, Trapp, Michael wrote:
> 
> 
> On 24.10.18, 00:09, Jim Fehlig  wrote:
> 
>      The use of WITH_XENSTORE in vm-dump-metrics is clumbsy in some
>      cases and flat out wrong in others. E.g. if WITH_XENSTORE is not
>      defined then vbd transport is excluded as an option for retrieving
>      the metrics. Improve use of WITH_XENSTORE and fix the broken logic.
>      
>      Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>      ---
>       vm-dump-metrics/main.c | 44 +++++++++++++++++++++---------------------
>       1 file changed, 22 insertions(+), 22 deletions(-)
>      
> reviewed and build on SLES15
> looks good to me

Thanks for the second set of eyes and increasing our tiny review bandwidth for 
vhostmd! :-) I've pushed the patches now so you can rebase your work on this 
cleanup.

Regards,
Jim




More information about the virt-tools-list mailing list