[virt-tools-list] [virt-manager PATCH] virt-install: Use minutes instead of seconds on get_time_string()

[Cole Robinson]

On 7/25/19 8:09 AM, Fabiano Fidêncio wrote:
> get_time_string() currently uses self._wait_secs, while it should use
> self._wait_mins, resulting on confusing messages when using `--wait`
> option, as shown below:
> 
> fidencio at laerte ~/src/upstream/virt-manager $ ./virt-install --install fedora30 --unattended --wait 20
>  ...
> Waiting 1200 minutes for installation to complete.
> 
> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> ---
>  virt-install | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/virt-install b/virt-install
> index af6c75bf..8efa4960 100755
> --- a/virt-install
> +++ b/virt-install
> @@ -610,7 +610,7 @@ class WaitHandler:
>          self._start_time = time.time()
>  
>      def get_time_string(self):
> -        timestr = _(" %d minutes") % self._wait_secs
> +        timestr = _(" %d minutes") % self._wait_mins
>          if self._wait_forever:
>              timestr = ""
>          ret = _("Waiting%(time_string)s for installation to complete.") % {
> 

Oops

Reviewed-by: Cole Robinson <crobinso at redhat.com>

And pushed

- Cole