[Virtio-fs] [Qemu-devel] [PATCH RESEND 0/2] virtiofsd: use "fuse_log.h" APIs instead of <err.h>
Dr. David Alan Gilbert
dgilbert at redhat.com
Thu Sep 5 10:36:13 UTC 2019
* Philippe Mathieu-Daudé (philmd at redhat.com) wrote:
> Hi Stefan,
>
> On 9/5/19 10:29 AM, Stefan Hajnoczi wrote:
> > warn(3), warnx(3), err(3), and errx(3) print to stderr even when the --syslog
> > option was given. In this case messages to stderr are likely to be lost and
> > this makes troubleshooting hard. Use "fuse_log.h" APIs instead of <err.h>.
> >
> > Stefan Hajnoczi (2):
> > virtiofsd: replace warn(3) and warnx(3) with fuse_warning()
> > virtiofsd: replace err(3) and errx(3) with fuse_err()
>
> Is this a straight RESEND or are there any changes in this series?
>
> I'm asking because IIRC your first series had:
> - Reviewed-by: Jun Piao <piaojun at huawei.com>
> - Reviewed-by: Philippe Mathieu-Daudé <philmd at redhat.com>
>
> If this isn't a RESEND then I'll review it again.
I'll pick those reviews up.
Dave
> Thanks,
>
> Phil.
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs at redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert at redhat.com / Manchester, UK
More information about the Virtio-fs
mailing list