[Workman-devel] [PATCH] CLI: workman command line interface framework

Josh Poimboeuf jpoimboe at redhat.com
Fri Apr 19 01:28:40 UTC 2013


On 04/18/2013 05:03 AM, Daniel P. Berrange wrote:
> On Wed, Apr 17, 2013 at 03:07:47PM -0500, Josh Poimboeuf wrote:
>> NOTE: This compiles but doesn't actually work yet.  It will need some of the
>> patches still under review on the mailing list (particularly the WorkmanManager
>> patch at least), a dummy plugin, as well as some additional fixes.
>>
>> The additional fixes include checking for NULL pointers before calling
>> g_object_free or g_boxed_free throughout libworkman, as well as calling
>> g_type_init() in workman_init_check().
>>
>> Daniel, I haven't posted those fixes since you're making some changes to
>> libworkman.  I'll post them and a dummy plugin later once your changes to
>> libworkman have been sorted out.
>
> Hmm, just push the previously posted patches that this requires. I don't
> want to hold you up on this. I'm fine with rebasing my work to latest
> GIT whenever I need to.

Ok.  I pushed the following unreviewed patches:

   WorkmanObject: minor fixes
   Makefile: Add private headers to SOURCES
   WorkmanManager: add properties and implementation


Josh




More information about the Workman-devel mailing list