[Workman-devel] [PATCH 1/7] Fix workman_DEBUG typo

[Daniel P. Berrange]

On Fri, Feb 22, 2013 at 04:46:50PM -0600, Josh Poimboeuf wrote:
> Change the workman_DEBUG comment to WORKMAN_DEBUG.
> ---
>  workman/workman-main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/workman/workman-main.c b/workman/workman-main.c
> index 6d67921..75be629 100644
> --- a/workman/workman-main.c
> +++ b/workman/workman-main.c
> @@ -75,7 +75,7 @@
>   * standard arguments.
>   *
>   * This method will also turn on debug logging of the library if the
> - * <literal>workman_DEBUG</literal> environment variable is set.
> + * <literal>WORKMAN_DEBUG</literal> environment variable is set.
>   *
>   * This function will terminate your program if it was unable to initialize
>   * for some reason. If you want the program to fall back to an alternate

ACK,

In projects I work on where we require ACKs before pushing to GIT master,
we normally have "trivial patch" and "build breaker" exceptions, and it
is probably worth following this practice for workman too.

If a patch is a minor docs typo fix or something similarly small which
does not have functional effects, then it is OK to merely post the patch
to the list, with a comment saying "Pushed under trivial patch rule".

Similarly if the build of GIT master is currently broken, it is generally
ok to push a build fix immediately, also posting the fix to the mailing
list with a comment "Pushed as a build breaker fix"

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|