[zanata-bugs] [Bug 748727] US31 As a translator I want the appropriate character encoding for my language to be used so that the content is saved in the correct encoding format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=748727

--- Comment #9 from Sean Flanigan <sflaniga at redhat.com> 2011-12-13 18:57:17 EST ---
(In reply to comment #7)
> Hi Sean,
> 
> > We should accept ASCII too, so I hope it's not case sensitive.
> 
> OK, i will add ASCII too.
> 
> > Is polib trying to auto-detect the encoding, or is it using the charset
> > encoding metadata from the Gettext header?  
> 
> polib will use the charset encoding metadata from the Gettext Header, then if
> it is not an supported encoding of python, then it will use UTF-8 instead. 
> 
> >The Python standard encodings do
> > seem to include UTF-8, are you just saying that it will try the other encodings
> > first?
> 
> Yeah, i am saying that polib will try the other encodings first, if it is an
> supported encoding and set in charset encoding metadata from the Gettext
> Header, like iso-8859-1, iso-8859-15, ascii, latin1, gbk, etc. 
> 
> >>>I think we could get away with accepting any POT file where charset has one of
> >>>the above three values (plus UTF8, ASCII) without warning, and accepting
> >>>anything else with a warning, but treating it as UTF-8 anyway.
> 
> For example, if the charset encoding metadata from the Gettext is set to gbk,
> polib will decode po file with gbk but not UTF-8, since gbk is supported by
> python. So i just want to make sure that we do want to force UTF-8 in this
> situation.

No, using the encoding from the Gettext header, or failing that the
auto-detected encoding, should be fine.  

We don't need to force UTF-8 if polib can do better than that; it's just that
UTF-8 seemed like a reasonable compromise.

Does polib tell you when it has to use auto-detection, rather than the Gettext
header?  If so, we could generate a warning in that case.  Otherwise I don't
think a warning is needed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.