[zanata/zanata-server] fe9691: Make RFC2822 and username tests use Theories rathe...

[GitHub]

  Branch: refs/heads/register-functional-tests
  Home:   https://github.com/zanata/zanata-server
  Commit: fe9691c874b0ba31fed84d92c9a7854aa5bc25e3
      https://github.com/zanata/zanata-server/commit/fe9691c874b0ba31fed84d92c9a7854aa5bc25e3
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/page/account/RegisterPage.java
    M functional-test/src/main/java/org/zanata/util/RFC2822.java
    A functional-test/src/test/java/org/zanata/feature/account/RFC2822NegativeTest.java
    A functional-test/src/test/java/org/zanata/feature/account/RFC2822PositiveTest.java
    M functional-test/src/test/java/org/zanata/feature/account/RegisterDetailedTest.java
    A functional-test/src/test/java/org/zanata/feature/account/RegisterTestSuite.java
    A functional-test/src/test/java/org/zanata/feature/account/UsernameValidationTest.java
    M functional-test/src/test/java/org/zanata/feature/glossary/GlossaryTestSuite.java

  Log Message:
  -----------
  Make RFC2822 and username tests use Theories rather than loops

Control functions (for, if, etc) in tests are bad. The (experimental) Therories
class looks to handle data based tests quite elegantly.
Move username and email validation to separate classes to test.
Also, fix minor bug in GlossaryTestSuite (database reset rules) and
give the Register tests a waitFor for the fields/errors to become visible,
to prevent element stale / not found problems.