[zanata/zanata-server] 0bad9f: User Registration tests

[GitHub]

  Branch: refs/heads/integration/master
  Home:   https://github.com/zanata/zanata-server
  Commit: 0bad9feb50c94fe490cecb4c909b104875c57b3d
      https://github.com/zanata/zanata-server/commit/0bad9feb50c94fe490cecb4c909b104875c57b3d
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-07-09 (Tue, 09 Jul 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/page/HomePage.java
    A functional-test/src/main/java/org/zanata/page/account/RegisterPage.java
    A functional-test/src/main/java/org/zanata/util/RFC2822.java
    A functional-test/src/test/java/org/zanata/feature/account/RegisterDetailedTest.java
    M zanata-war/src/main/webapp/account/register.xhtml

  Log Message:
  -----------
  User Registration tests

Currently, successful registration testing is blocked by Captcha validation.
Includes register page, and testcases for field validation on usernames and
email RFC2822 compliance.
Basic validation for password matching and Captcha rejection.


  Commit: 96d8f0598490355aeb518daafd8895fceaa413f8
      https://github.com/zanata/zanata-server/commit/96d8f0598490355aeb518daafd8895fceaa413f8
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-07-09 (Tue, 09 Jul 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/util/RFC2822.java

  Log Message:
  -----------
  Better description of the RFC2822 class

The description was lacking / inaccurate.


  Commit: fe9691c874b0ba31fed84d92c9a7854aa5bc25e3
      https://github.com/zanata/zanata-server/commit/fe9691c874b0ba31fed84d92c9a7854aa5bc25e3
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/page/account/RegisterPage.java
    M functional-test/src/main/java/org/zanata/util/RFC2822.java
    A functional-test/src/test/java/org/zanata/feature/account/RFC2822NegativeTest.java
    A functional-test/src/test/java/org/zanata/feature/account/RFC2822PositiveTest.java
    M functional-test/src/test/java/org/zanata/feature/account/RegisterDetailedTest.java
    A functional-test/src/test/java/org/zanata/feature/account/RegisterTestSuite.java
    A functional-test/src/test/java/org/zanata/feature/account/UsernameValidationTest.java
    M functional-test/src/test/java/org/zanata/feature/glossary/GlossaryTestSuite.java

  Log Message:
  -----------
  Make RFC2822 and username tests use Theories rather than loops

Control functions (for, if, etc) in tests are bad. The (experimental) Therories
class looks to handle data based tests quite elegantly.
Move username and email validation to separate classes to test.
Also, fix minor bug in GlossaryTestSuite (database reset rules) and
give the Register tests a waitFor for the fields/errors to become visible,
to prevent element stale / not found problems.


  Commit: 189970abf372f47227c43e38466d7bd7da16dacf
      https://github.com/zanata/zanata-server/commit/189970abf372f47227c43e38466d7bd7da16dacf
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-07-11 (Thu, 11 Jul 2013)

  Changed paths:
    R functional-test/src/main/java/org/zanata/util/RFC2822.java
    A functional-test/src/main/java/org/zanata/util/rfc2822/InvalidEmailAddressRFC2822.java
    A functional-test/src/main/java/org/zanata/util/rfc2822/ValidEmailAddressRFC2822.java
    A functional-test/src/test/java/org/zanata/feature/account/InvalidEmailAddressTest.java
    R functional-test/src/test/java/org/zanata/feature/account/RFC2822NegativeTest.java
    R functional-test/src/test/java/org/zanata/feature/account/RFC2822PositiveTest.java
    M functional-test/src/test/java/org/zanata/feature/account/RegisterDetailedTest.java
    M functional-test/src/test/java/org/zanata/feature/account/RegisterTestSuite.java
    A functional-test/src/test/java/org/zanata/feature/account/ValidEmailAddressTest.java

  Log Message:
  -----------
  Improve the RFC2822 files to be more descriptive and clean

Split email addresses into valid and non-valid.
Use an enum for the address entries.
Improve docs.


  Commit: 41783d7964577c0dd65728ff14553c7a378b1bc4
      https://github.com/zanata/zanata-server/commit/41783d7964577c0dd65728ff14553c7a378b1bc4
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-07-14 (Sun, 14 Jul 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/page/HomePage.java
    M functional-test/src/main/java/org/zanata/util/rfc2822/InvalidEmailAddressRFC2822.java
    M functional-test/src/main/java/org/zanata/util/rfc2822/ValidEmailAddressRFC2822.java
    M functional-test/src/test/java/org/zanata/feature/account/InvalidEmailAddressTest.java
    M functional-test/src/test/java/org/zanata/feature/account/RegisterDetailedTest.java

  Log Message:
  -----------
  Fix some line length and function calls

Function calls (specifically new BasicWorkFlow) replaced.
Wrapped some long lines.


  Commit: bf195b65f9fcdca5c1ed8ce527a749b6e0736f70
      https://github.com/zanata/zanata-server/commit/bf195b65f9fcdca5c1ed8ce527a749b6e0736f70
  Author: Alex Eng <aeng at redhat.com>
  Date:   2013-07-15 (Mon, 15 Jul 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/page/HomePage.java
    A functional-test/src/main/java/org/zanata/page/account/RegisterPage.java
    A functional-test/src/main/java/org/zanata/util/rfc2822/InvalidEmailAddressRFC2822.java
    A functional-test/src/main/java/org/zanata/util/rfc2822/ValidEmailAddressRFC2822.java
    A functional-test/src/test/java/org/zanata/feature/account/InvalidEmailAddressTest.java
    A functional-test/src/test/java/org/zanata/feature/account/RegisterDetailedTest.java
    A functional-test/src/test/java/org/zanata/feature/account/RegisterTestSuite.java
    A functional-test/src/test/java/org/zanata/feature/account/UsernameValidationTest.java
    A functional-test/src/test/java/org/zanata/feature/account/ValidEmailAddressTest.java
    M functional-test/src/test/java/org/zanata/feature/glossary/GlossaryTestSuite.java
    M zanata-war/src/main/webapp/account/register.xhtml

  Log Message:
  -----------
  Merge pull request #31 from zanata/register-functional-tests

User Registration tests


Compare: https://github.com/zanata/zanata-server/compare/927db71ba400...bf195b65f9fc