[zanata/zanata-server] 2e832b: Refactor Copy Trans to be more testable.

[GitHub]

  Branch: refs/heads/integration/master
  Home:   https://github.com/zanata/zanata-server
  Commit: 2e832be3ee62f44e2c97c45f33443ce888163d68
      https://github.com/zanata/zanata-server/commit/2e832be3ee62f44e2c97c45f33443ce888163d68
  Author: Carlos A. Munoz <camunoz at redhat.com>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/dao/TextFlowTargetDAO.java
    M zanata-war/src/main/java/org/zanata/service/impl/CopyTransServiceImpl.java
    M zanata-war/src/test/java/org/zanata/service/impl/CopyTransServiceImplTest.java

  Log Message:
  -----------
  Refactor Copy Trans to be more testable.

Correct a previously inserted bug where translations from obsolete documents where not being reused.
Refactor Copy trans to be more functional and thus testable.
Add some tests to test these discrete pieces.


  Commit: 28321027a6907da2ed059d2391b2997081921e36
      https://github.com/zanata/zanata-server/commit/28321027a6907da2ed059d2391b2997081921e36
  Author: Carlos A. Munoz <camunoz at redhat.com>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/service/impl/CopyTransServiceImpl.java
    M zanata-war/src/test/java/org/zanata/service/impl/CopyTransServiceImplTest.java

  Log Message:
  -----------
  Rename ResultActionPair to MatchRulePair.


  Commit: d1dae05e6c647eb12506773b0cb5bc5b403fc2e4
      https://github.com/zanata/zanata-server/commit/d1dae05e6c647eb12506773b0cb5bc5b403fc2e4
  Author: Carlos A. Munoz <camunoz at redhat.com>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/service/impl/CopyTransServiceImpl.java

  Log Message:
  -----------
  Code review changes (See below).

Refactor method to use ternary operator.
Assume a non-nullable argument in copy trans internal method.


  Commit: 3512081da1f4ba861f77313cc855161d12474248
      https://github.com/zanata/zanata-server/commit/3512081da1f4ba861f77313cc855161d12474248
  Author: Carlos A. Munoz <camunoz at redhat.com>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/service/impl/CopyTransServiceImpl.java

  Log Message:
  -----------
  Refactor internal MatchRulePair class.


  Commit: da8e36ad77d9bc2b8aebe681dbd7bbd16d6b7849
      https://github.com/zanata/zanata-server/commit/da8e36ad77d9bc2b8aebe681dbd7bbd16d6b7849
  Author: Carlos A. Munoz <camunoz at redhat.com>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    A zanata-war/src/test/java/org/zanata/SlowTest.java
    M zanata-war/src/test/java/org/zanata/service/impl/CopyTransServiceImplTest.java

  Log Message:
  -----------
  Add @SlowTest annotation.

For now just a marker interface to identify potentially slow running tests.


  Commit: 3d0f8bd97f49b4ed804ee21e5f786c446270ebdc
      https://github.com/zanata/zanata-server/commit/3d0f8bd97f49b4ed804ee21e5f786c446270ebdc
  Author: Carlos A. Munoz <camunoz at redhat.com>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M zanata-war/src/test/java/org/zanata/SlowTest.java
    M zanata-war/src/test/java/org/zanata/service/impl/CopyTransServiceImplTest.java

  Log Message:
  -----------
  Change @SlowTest to be a method level annotation.


  Commit: 6166bea7a1a6ca06f8b9fffd99619662079ddc6d
      https://github.com/zanata/zanata-server/commit/6166bea7a1a6ca06f8b9fffd99619662079ddc6d
  Author: Sean Flanigan <sflaniga at redhat.com>
  Date:   2013-09-03 (Tue, 03 Sep 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/dao/TextFlowTargetDAO.java
    M zanata-war/src/main/java/org/zanata/service/impl/CopyTransServiceImpl.java
    A zanata-war/src/test/java/org/zanata/SlowTest.java
    M zanata-war/src/test/java/org/zanata/service/impl/CopyTransServiceImplTest.java

  Log Message:
  -----------
  Merge pull request #154 from zanata/copy-trans-changes

Refactor Copy Trans to be more testable.


  Commit: fd5944f361f3551c68e8ef467162011afc3ec44b
      https://github.com/zanata/zanata-server/commit/fd5944f361f3551c68e8ef467162011afc3ec44b
  Author: Carlos A. Munoz <camunoz at redhat.com>
  Date:   2013-09-04 (Wed, 04 Sep 2013)

  Changed paths:
    M zanata-war/src/main/java/org/zanata/dao/TextFlowTargetDAO.java
    M zanata-war/src/main/java/org/zanata/service/impl/CopyTransServiceImpl.java
    A zanata-war/src/test/java/org/zanata/SlowTest.java
    M zanata-war/src/test/java/org/zanata/service/impl/CopyTransServiceImplTest.java

  Log Message:
  -----------
  Merge branch 'release' into integration/master

Conflicts:
	zanata-war/src/main/java/org/zanata/service/impl/CopyTransServiceImpl.java


Compare: https://github.com/zanata/zanata-server/compare/85cbb4c7451c...fd5944f361f3