[zanata/zanata-server] 38681a: Source File Upload Tests

[GitHub]

  Branch: refs/heads/document-upload-tests
  Home:   https://github.com/zanata/zanata-server
  Commit: 38681a42332d793e0d6453a8e2f7181725718d46
      https://github.com/zanata/zanata-server/commit/38681a42332d793e0d6453a8e2f7181725718d46
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M functional-test/pom.xml
    M functional-test/src/main/java/org/zanata/page/BasePage.java
    A functional-test/src/main/java/org/zanata/page/projects/ProjectSourceDocumentsPage.java
    M functional-test/src/main/java/org/zanata/page/projects/ProjectVersionPage.java
    A functional-test/src/test/java/org/zanata/feature/document/UploadTest.java
    M functional-test/src/test/java/org/zanata/util/DatabaseHelper.java
    M functional-test/src/test/java/org/zanata/util/ResetDatabaseRule.java
    M functional-test/src/test/resources/setup.properties
    A functional-test/testdata/cancelFileUpload.txt
    A functional-test/testdata/uploadedDocumentIsInFilesystem.txt
    M zanata-war/src/main/webapp/iteration/source_files.xhtml

  Log Message:
  -----------
  Source File Upload Tests

Add Uploaded source files testing. Handles success and error case.
Exception located in error cases, these tests are expect fail.
Added a 'Critical Error' check to BasePage and some hard defaults
for the document storage dir.
Added an action to delete the stored files on database reset.
Slight modification of ids in Source Documents pages.


  Commit: 2b85d60ea3a04db90a1a50dbedce1ab8f56e8d79
      https://github.com/zanata/zanata-server/commit/2b85d60ea3a04db90a1a50dbedce1ab8f56e8d79
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M functional-test/src/test/java/org/zanata/feature/document/UploadTest.java

  Log Message:
  -----------
  Add too-large upload file test

Test for files that are too large to upload.


  Commit: 761d3cad415987042b65c359460333535440e08b
      https://github.com/zanata/zanata-server/commit/761d3cad415987042b65c359460333535440e08b
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/page/BasePage.java
    M functional-test/src/main/java/org/zanata/page/projects/ProjectSourceDocumentsPage.java
    M functional-test/src/test/java/org/zanata/feature/document/UploadTest.java
    M functional-test/src/test/java/org/zanata/util/DatabaseHelper.java
    M functional-test/src/test/resources/setup.properties

  Log Message:
  -----------
  Fix up code review issues in Source Upload testing

Mostly blank lines and readbility.


  Commit: cf343ae8a1210a006130b4da054d174d7f4926f2
      https://github.com/zanata/zanata-server/commit/cf343ae8a1210a006130b4da054d174d7f4926f2
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M functional-test/src/main/java/org/zanata/page/projects/ProjectSourceDocumentsPage.java
    M functional-test/src/test/java/org/zanata/feature/document/UploadTest.java

  Log Message:
  -----------
  Update UploadTest on review comments

Don't use globals for elements that may not exist.
Clear cached data between functions.
Wrong licence year.
Also added a test step for verifying the file is saved to the intended
location.


  Commit: 3c8c9ed4f302bc379422e8b5cb085d9d449ca0a3
      https://github.com/zanata/zanata-server/commit/3c8c9ed4f302bc379422e8b5cb085d9d449ca0a3
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M functional-test/pom.xml
    M functional-test/src/main/java/org/zanata/page/projects/ProjectSourceDocumentsPage.java
    A functional-test/src/main/java/org/zanata/util/TestFileGenerator.java
    M functional-test/src/test/java/org/zanata/feature/document/UploadTest.java
    M functional-test/src/test/resources/setup.properties
    M zanata-war/src/main/webapp/iteration/source_files.xhtml

  Log Message:
  -----------
  Use a generator instead of static files for testing

Rather than dumping a bunch of files in a dir, just use a generator
to create temp files.
Add a few more Upload tests to make use of this.


  Commit: eeefee8aceb8fa2dc650f0c2f814715231da2902
      https://github.com/zanata/zanata-server/commit/eeefee8aceb8fa2dc650f0c2f814715231da2902
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M functional-test/src/test/java/org/zanata/util/DatabaseHelper.java
    M functional-test/src/test/java/org/zanata/util/ResetDatabaseRule.java

  Log Message:
  -----------
  Completely clear and rebuild the h2 database on reset

The sql backup procedure for the first run scenario writes the
sequence lines without the "if not exists" clause, so subsequent
runs can fail - especially after the user has executed some
tests manually.
Drop all items from the database and either restore a base from
the backup or a complete database with test data.


  Commit: ad51fb77ada85e969b3712b389985e6f298c6a2a
      https://github.com/zanata/zanata-server/commit/ad51fb77ada85e969b3712b389985e6f298c6a2a
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    R functional-test/testdata/cancelFileUpload.txt
    R functional-test/testdata/uploadedDocumentIsInFilesystem.txt

  Log Message:
  -----------
  Remove leftover test files from previous commit


  Commit: d5a9b0527402983a03ea5494f79cc238468cb75b
      https://github.com/zanata/zanata-server/commit/d5a9b0527402983a03ea5494f79cc238468cb75b
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M functional-test/src/test/java/org/zanata/util/DatabaseHelper.java
    M functional-test/src/test/resources/concordion/org/zanata/feature/zanata_with_data.sql

  Log Message:
  -----------
  Update database table count and data generation script

Table count is now 81.
Two Transmemory _METADATA tables have been dropped.


  Commit: 011b1022a81e14c36148e31e5eee93d3e18c1180
      https://github.com/zanata/zanata-server/commit/011b1022a81e14c36148e31e5eee93d3e18c1180
  Author: Damian Jansen <djansen at redhat.com>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M functional-test/pom.xml

  Log Message:
  -----------
  Add commons-io dependency for test generator

Functional test pom.xml was missing the required dependencies for
new features.


Compare: https://github.com/zanata/zanata-server/compare/836c49477097...011b1022a81e